Avoid consulting clock twice between HugePageFiller and TimeSeriesTracker. - #700
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Avoid consulting clock twice between HugePageFiller and TimeSeriesTracker.#700copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_978596975
branch
2 times, most recently
from
September 9, 2026 21:52
831000c to
a8c80e2
Compare
…cker. HugePageFiller::Allocate and HugePageFiller::Put previously queried the cycle clock multiple times in the same operation (once for lifetime/allocation tracking and once inside TimeSeriesTracker::Report). Thread the existing timestamp to SubreleaseStatsTracker::Report and UpdateFillerStatsTracker. In legacy locking mode (TCMALLOC_INTERNAL_LEGACY_LOCKING), expose now as a dead parameter and query the cycle clock locally to preserve baseline behavior for ablation testing. PiperOrigin-RevId: 978596975
copybara-service
Bot
force-pushed
the
test_978596975
branch
from
September 10, 2026 03:05
a8c80e2 to
9e6d191
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid consulting clock twice between HugePageFiller and TimeSeriesTracker.
HugePageFiller::Allocate and HugePageFiller::Put previously queried the cycle
clock multiple times in the same operation (once for lifetime/allocation
tracking and once inside TimeSeriesTracker::Report). Thread the existing
timestamp to SubreleaseStatsTracker::Report and UpdateFillerStatsTracker.
In legacy locking mode (TCMALLOC_INTERNAL_LEGACY_LOCKING), expose now as a dead
parameter and query the cycle clock locally to preserve baseline behavior for
ablation testing.